Skip to content

ROX-33204: Upgrade Prettier 3.8.1#19466

Open
pedrottimark wants to merge 1 commit intomasterfrom
ROX-33204-devDependencies-prettier-3.8.1
Open

ROX-33204: Upgrade Prettier 3.8.1#19466
pedrottimark wants to merge 1 commit intomasterfrom
ROX-33204-devDependencies-prettier-3.8.1

Conversation

@pedrottimark
Copy link
Contributor

Description

We waited until after PatternFly 6 upgrade to minimize merge conflicts

https://prettier.io/blog/2026/01/14/3.8.0

Prettier now fully supports the fresh features landing in Angular v21.1

https://prettier.io/blog/2025/11/27/3.7.0

we also fixed lots of bugs

https://prettier.io/blog/2025/11/27/3.7.0#change-17882

Avoid break {import,require.resolve,require.resolve.paths,import.meta.resolve}() with long module name

https://prettier.io/blog/2025/11/27/3.7.0#change-18205

Fix inconsistent logical expression print

User-facing documentation

  • CHANGELOG.md update is not needed
  • documentation PR is not needed

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

  1. npm run tsc in ui/apps/platform folder.

  2. npm run lint:fast-dev in ui/apps/platform folder.

    19 problems in 4 files

  3. npm run lint:fast-dev-fix in ui/apps/platform folder.

@pedrottimark pedrottimark requested review from a team as code owners March 17, 2026 19:07
@rhacs-bot
Copy link
Contributor

Images are ready for the commit at 73369d2.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-354-g73369d2ce3.

@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.32%. Comparing base (9f63a02) to head (73369d2).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #19466   +/-   ##
=======================================
  Coverage   49.32%   49.32%           
=======================================
  Files        2722     2722           
  Lines      205171   205163    -8     
=======================================
+ Hits       101196   101197    +1     
+ Misses      96442    96432   -10     
- Partials     7533     7534    +1     
Flag Coverage Δ
go-unit-tests 49.32% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants