Skip to content

ROX-33465: Rework openshift auto-sensing in Helm chart#19482

Open
mclasmeier wants to merge 3 commits intomasterfrom
mc/ROX-33465-openshift-autosensing
Open

ROX-33465: Rework openshift auto-sensing in Helm chart#19482
mclasmeier wants to merge 3 commits intomasterfrom
mc/ROX-33465-openshift-autosensing

Conversation

@mclasmeier
Copy link
Contributor

@mclasmeier mclasmeier commented Mar 18, 2026 •
edited
Loading

Description

The auto-sensing for openshift is completely reorganized.
It now contains an additional (higher-priority) check for the config.openshift.io/v1 API (CRD based, hence more reliable).

I had to keep the remaining logic because we also support OpenShift 3 and config.openshift.io/v1 is OpenShift 4-only.

The new code structure allows improved logs in case we have a discrepancy between the auto-sensed cluster type and what the user has specified.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@openshift-ci
Copy link

openshift-ci bot commented Mar 18, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Mar 18, 2026 •
edited
Loading

Images are ready for the commit at 67a6276.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-363-g67a6276f46.

@codecov
Copy link

codecov bot commented Mar 18, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.26%. Comparing base (2b34e97) to head (67a6276).
⚠️ Report is 19 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #19482   +/-   ##
=======================================
  Coverage   49.25%   49.26%           
=======================================
  Files        2725     2726    +1     
  Lines      205582   205626   +44     
=======================================
+ Hits       101268   101310   +42     
  Misses      96780    96780           
- Partials     7534     7536    +2
Flag Coverage Δ
go-unit-tests 49.26% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mclasmeier mclasmeier force-pushed the mc/ROX-33465-openshift-autosensing branch from 9d45c67 to 219d34f Compare March 18, 2026 15:53
@mclasmeier mclasmeier changed the title Rework openshift auto-sensing in Helm chart to also check for config.… ROX-33465: Rework openshift auto-sensing in Helm chart Mar 18, 2026
@mclasmeier mclasmeier marked this pull request as ready for review March 18, 2026 16:16
@mclasmeier mclasmeier requested a review from a team as a code owner March 18, 2026 16:16
@mclasmeier mclasmeier requested review from GrimmiMeloni and removed request for a team March 18, 2026 16:16
@mclasmeier mclasmeier requested a review from porridge March 18, 2026 16:56
@openshift-ci
Copy link

openshift-ci bot commented Mar 19, 2026

@mclasmeier: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-20-qa-e2e-tests 67a6276 link false /test ocp-4-20-qa-e2e-tests
ci/prow/ocp-4-12-scanner-v4-install-tests 67a6276 link false /test ocp-4-12-scanner-v4-install-tests
ci/prow/ocp-4-20-scanner-v4-install-tests 67a6276 link false /test ocp-4-20-scanner-v4-install-tests
ci/prow/ocp-4-21-scanner-v4-install-tests 67a6276 link false /test ocp-4-21-scanner-v4-install-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GrimmiMeloni GrimmiMeloni Awaiting requested review from GrimmiMeloni GrimmiMeloni is a code owner automatically assigned from stackrox/install

@porridge porridge Awaiting requested review from porridge

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

area/helm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mclasmeier @rhacs-bot