ROX-33427: Add correct version to OCP plugin metadata#19486
ROX-33427: Add correct version to OCP plugin metadata#19486
Conversation
|
This change is part of the following stack: Change managed by git-spice. |
|
Skipping CI for Draft Pull Request. |
|
Images are ready for the commit at 03c13a0. To use with deploy scripts, first |
| it('should display plugin information in cluster settings', () => { | ||
| visitFromConsoleLeftNavExpandable('Administration', 'Dynamic Plugins'); | ||
|
|
||
| cy.get('td[data-label="name"]:contains("advanced-cluster-security")') |
There was a problem hiding this comment.
To keep my mind active and exercise paranoia: in testing environment:
- Pagination is not an issue, I assume?
- Even if it was,
advanmced-cluster-securitymight save us, somewhat like what happened with admission control as first row of table?
There was a problem hiding this comment.
Pagination is not an issue, I assume?
Unlikely, the default pagination requests 250 items for this screen. Compounded by your second point, as long as we do not have 250 active plugins that occur alphabetically before advanced-cluster-security, we would be OK.
| validateSharedModules: false, | ||
| pluginMetadata: { | ||
| name: 'advanced-cluster-security', | ||
| version: '0.0.1', |
There was a problem hiding this comment.
Brings back memories of scavenger hunt for stray stuff at the acquisition.
|
@dvail: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Sets the version of the dynamic plugin to match the released product version, instead of the hard coded
0.0.1from Tech Preview.User-facing documentation
Testing and quality
Automated testing
How I validated my change
👀 and new e2e test
