fix(tests): update Splunk TA integration test for UCC-based TA#19488
Draft
fix(tests): update Splunk TA integration test for UCC-based TA#19488
Conversation
The Splunk TA was migrated from Add-on Builder to UCC framework but the integration test was never updated. The test was silently broken in CI because postToSplunk never checked HTTP response status. - Upgrade Splunk image from 9.0.5 (EOL, Python 3.7) to 9.4.6 (Python 3.9) to support modern TA dependencies (typing_extensions 4.13+) - Replace stale .spl artifact with TA-stackrox-2.0.5.spl built from current UCC-based source - Fix input creation: use UCC REST handler path (TA_stackrox_stackrox_violations) and add required index parameter - Fix saved search name: use unencoded spaces instead of %20 to avoid REST Assured double-encoding - Fix CIM field expectations: user and dest produce "unknown" (not null) when source fields are absent - Add HTTP status assertions to postToSplunk, createSearch, and getSearchResults to catch silent failures - Remove redundant sleep(15) from search retry loops Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Skipping CI for Draft Pull Request. |
Contributor
|
Images are ready for the commit at 775d656. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19488 +/- ##
=======================================
Coverage 49.26% 49.27%
=======================================
Files 2725 2726 +1
Lines 205600 205626 +26
=======================================
+ Hits 101286 101314 +28
+ Misses 96777 96775 -2
Partials 7537 7537
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Splunk TA was migrated from Add-on Builder to UCC framework but the integration test was never updated. The test was silently broken in CI because postToSplunk never checked HTTP response status.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!