refactor: move access scope protobuf validation to pkg/sac#19502
Open
rhybrillou wants to merge 1 commit intomasterfrom
Open
refactor: move access scope protobuf validation to pkg/sac#19502rhybrillou wants to merge 1 commit intomasterfrom
rhybrillou wants to merge 1 commit intomasterfrom
Conversation
|
Skipping CI for Draft Pull Request. |
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since this refactor moves access scope validation into pkg/sac/accessscope, consider scanning the codebase for remaining imports of pkg/accessscope and updating them for consistency with the new package location.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since this refactor moves access scope validation into pkg/sac/accessscope, consider scanning the codebase for remaining imports of pkg/accessscope and updating them for consistency with the new package location.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
Images are ready for the commit at 924360c. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19502 +/- ##
==========================================
- Coverage 49.71% 49.26% -0.45%
==========================================
Files 2701 2726 +25
Lines 203453 205625 +2172
==========================================
+ Hits 101140 101308 +168
- Misses 94786 96780 +1994
- Partials 7527 7537 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is part of the split of #19351
The split results in the following stack of PRs:
The current PR focuses on bringing the
pkg/accessscopesubdirectory topkg/sac. A comment in #19351 highlighted a missed update in the moved directory. Bringing it to thepkg/sacsubtree may reduce the risk of overlooking the structure validation when the protocol buffer structures related to access control are changed.Actual changes to the moved files will come in #19505
User-facing documentation
is updated ORupdate is not neededis created and is linked above ORis not neededTesting and quality
Automated testing
N/A - this PR only moves directories around but does not change the behaviour of the actual codebase.
How I validated my change
CI