Skip to content

chore: use correct versions in go.mod#19508

Closed
janisz wants to merge 3 commits intomasterfrom
chore-use-correct-versions-in-go.mod
Closed

chore: use correct versions in go.mod#19508
janisz wants to merge 3 commits intomasterfrom
chore-use-correct-versions-in-go.mod

Conversation

@janisz
Copy link
Contributor

@janisz janisz commented Mar 19, 2026

Description

We are using phony version of replaced modules and that causes stackrox-mcp that depends on stackrox to have same replacement as well. If we use normal versions then we don't need this.

https://github.com/stackrox/stackrox-mcp/blob/7cb69891cec7d6882eadba84192d1faeed1991db/go.mod#L47-L54

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@janisz janisz requested a review from a team as a code owner March 19, 2026 14:43
@janisz janisz closed this Mar 19, 2026
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Mar 19, 2026

Images are ready for the commit at 0f60189.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-384-g4e05743520.

@janisz janisz reopened this Mar 20, 2026
@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.26%. Comparing base (119a398) to head (8f2b86a).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #19508   +/-   ##
=======================================
  Coverage   49.26%   49.26%           
=======================================
  Files        2726     2726           
  Lines      205625   205625           
=======================================
+ Hits       101302   101305    +3     
+ Misses      96784    96781    -3     
  Partials     7539     7539           
Flag Coverage Δ
go-unit-tests 49.26% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@openshift-ci
Copy link

openshift-ci bot commented Mar 20, 2026

@janisz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-nongroovy-e2e-tests 0f60189 link false /test ocp-4-12-nongroovy-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@janisz janisz closed this Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants