Conversation
Contributor
|
Images are ready for the commit at d28e3b9. To use with deploy scripts, first |
1 similar comment
Contributor
|
Images are ready for the commit at d28e3b9. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19519 +/- ##
==========================================
- Coverage 49.27% 49.23% -0.04%
==========================================
Files 2726 2727 +1
Lines 205625 205764 +139
==========================================
- Hits 101312 101310 -2
- Misses 96777 96916 +139
- Partials 7536 7538 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dashrews78
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
openshift-network-consolenamespace to the platform component layered products definition. During console plugin development work, it was discovered that this namespace was missing from the CORE SYSTEM definition used to identify Red Hat-managed platform components.Related JIRA: https://redhat.atlassian.net/browse/ROX-33672
User-facing documentation
CHANGELOG.md is updated OR update is not needed
documentation PR is created and is linked above OR is not needed
Testing and quality
the change is production ready: the change is GA, or otherwise the functionality is gated by a feature
flag
CI results are inspected
Automated testing
How I validated my change
go test ./central/config/datastore/...- all tests passopenshift-network-consoleexactly and doesn't match partial strings