Skip to content

ROX-33327: WIP - Coalesce image scan requests originating from admiss…#19523

Draft
clickboo wants to merge 2 commits intomasterfrom
boo-adm-ctrl-coalesce
Draft

ROX-33327: WIP - Coalesce image scan requests originating from admiss…#19523
clickboo wants to merge 2 commits intomasterfrom
boo-adm-ctrl-coalesce

Conversation

@clickboo
Copy link
Contributor

…ion controller webhooks

Description

change me!

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@openshift-ci
Copy link

openshift-ci bot commented Mar 20, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

sourcery-ai[bot]

This comment was marked as outdated.

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Mar 20, 2026

Images are ready for the commit at 6c831af.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-396-g6c831af743.

@clickboo clickboo force-pushed the boo-adm-ctrl-coalesce branch from f30251a to 864b775 Compare March 20, 2026 16:07
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

❌ Patch coverage is 25.00000% with 66 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.24%. Comparing base (c2045aa) to head (6c831af).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
sensor/admission-control/manager/images.go 33.84% 43 Missing ⚠️
...nsor/admission-control/manager/evaluate_runtime.go 0.00% 10 Missing ⚠️
sensor/admission-control/manager/manager_impl.go 0.00% 7 Missing ⚠️
...r/admission-control/manager/evaluate_deploytime.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19523      +/-   ##
==========================================
+ Coverage   49.23%   49.24%   +0.01%     
==========================================
  Files        2727     2727              
  Lines      205764   205803      +39     
==========================================
+ Hits       101304   101350      +46     
+ Misses      96921    96917       -4     
+ Partials     7539     7536       -3     
Flag Coverage Δ
go-unit-tests 49.24% <25.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants