Open
Conversation
Contributor
|
Images are ready for the commit at 0402bb0. To use with deploy scripts, first |
AlexVulaj
reviewed
Mar 20, 2026
AlexVulaj
approved these changes
Mar 20, 2026
c-du
approved these changes
Mar 20, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #19531 +/- ##
==========================================
- Coverage 49.24% 49.24% -0.01%
==========================================
Files 2727 2727
Lines 205787 205794 +7
==========================================
Hits 101345 101345
- Misses 96906 96913 +7
Partials 7536 7536
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
central/deployment/datastore/internal/store/postgres/full_store.go: ContainerImagesView in deployment store should clone the passed query to avoid modifying the original query.central/image/datastore/singleton.go: Skip initializing old image datastore when FlattenImage flag is enabledcentral/image/service/service_impl.go: ClusterLocal images should be re-enriched (not just pulled existing image from db) after the scan is expired. This check exists for old image model. It was missed when adding equivalent functions for ImageV2Changes were assisted by Cursor
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Updated unit tests to verify changes to image service. Changes to deployment datastore and image datastore singleton didn't break anything but are good to have.