Skip to content

DON'T REVIEW Jv all process indicator metrics#19532

Draft
JoukoVirtanen wants to merge 25 commits intomasterfrom
jv-all-process-indicator-metrics
Draft

DON'T REVIEW Jv all process indicator metrics#19532
JoukoVirtanen wants to merge 25 commits intomasterfrom
jv-all-process-indicator-metrics

Conversation

@JoukoVirtanen
Copy link
Contributor

@JoukoVirtanen JoukoVirtanen commented Mar 21, 2026

Just for testing

JoukoVirtanen and others added 25 commits March 18, 2026 22:53
@JoukoVirtanen
X-Smart-Branch-Parent: master
8c24cc0
@JoukoVirtanen
Added metrics for histogram of argument length, total bytes of argume…
fa2b9d3 
…nts stored, and number of process indicators inserted
@JoukoVirtanen
Removed a redundant metric
8a3b701
@JoukoVirtanen
Removed recordProcessIndicatorAdded
7057af7
@JoukoVirtanen
Added a metric for the number of characters in arguments
06dcc77
@JoukoVirtanen
Removed processIndicatorsAddedCounter
df35517
@JoukoVirtanen
Removed process_args_size_bytes metric
2d9b9c0
@JoukoVirtanen
Renamed process_args_size_chars to process_upserted_args_size
9c5e5bc
@JoukoVirtanen
The metric takes in the cluster id as a parameter
2e2e1bf
@JoukoVirtanen
Process arguments lengths are now specified by cluster and namespace
99b09d1
@JoukoVirtanen
There is just one histogram for central. Argument lengths are still b…
3ba4841 
…roken down by cluster and namespace
@JoukoVirtanen @erthalion
Update central/processindicator/datastore/metrics.go
ac515c4 
Co-authored-by: Dmitrii Dolgov <9erthalion6@gmail.com>
@JoukoVirtanen
Added comment explaining usage of RuneCountInString
0653d26
@JoukoVirtanen
Added processUpsertedCount by cluster id and namespace
32f80fa
@JoukoVirtanen
X-Smart-Branch-Parent: jv-ROX-32873-metrics-for-process-arguments
48eeb8a
@JoukoVirtanen
Added a metric for lineage info
61e8bdb
@JoukoVirtanen
There is just one histogram for central. Process lineage lengths are …
d9c13c2 
…still broken down by cluster and namespace
@JoukoVirtanen
Added word upserted to metric description
c386499
@JoukoVirtanen
X-Smart-Branch-Parent: jv-ROX-32873-metrics-for-process-arguments
998eb1c
@JoukoVirtanen
X-Smart-Squash: Squashed 5 commits:
69cf2f4 
2500d11 Added metrics for different types of process indicator pruning, total pruned, and net processes
7669364 Fixed unit test
4ac0e98 Not doing two queries to delete process indicators
79f5280 Removed metric for net process indicators
30ca3db Fixed style
@JoukoVirtanen
Fixed error from rebase
a527a8b
@JoukoVirtanen
X-Smart-Branch-Parent: master
7b01717
@JoukoVirtanen
Merge branch 'jv-ROX-32873-metrics-for-process-arguments' into jv-all…
d1c57c7 
…-process-indicator-metrics
@JoukoVirtanen
Merge branch 'jv-ROX-33352-add-histogram-of-lineage-size' into jv-all…
ee228f9 
…-process-indicator-metrics
@JoukoVirtanen
Merge jv-ROX-33267-metrics-to-keep-track-of-pruned-process-indicators
fba1716
@JoukoVirtanen JoukoVirtanen added the do-not-merge A change which is not meant to be merged label Mar 21, 2026
@openshift-ci
Copy link

openshift-ci bot commented Mar 21, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Mar 21, 2026

Images are ready for the commit at fba1716.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-403-gfba1716e9b.

@codecov
Copy link

codecov bot commented Mar 21, 2026

Codecov Report

❌ Patch coverage is 85.29412% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.26%. Comparing base (a083ce7) to head (fba1716).
⚠️ Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
central/processindicator/datastore/metrics.go 86.36% 6 Missing ⚠️
...ntral/processindicator/datastore/datastore_impl.go 82.35% 2 Missing and 1 partial ⚠️
central/detection/lifecycle/manager_impl.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #19532      +/-   ##
==========================================
- Coverage   49.26%   49.26%   -0.01%     
==========================================
  Files        2726     2727       +1     
  Lines      205626   205839     +213     
==========================================
+ Hits       101304   101399      +95     
- Misses      96784    96902     +118     
  Partials     7538     7538
Flag Coverage Δ
go-unit-tests 49.26% <85.29%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/central do-not-merge/work-in-progress do-not-merge A change which is not meant to be merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoukoVirtanen @rhacs-bot