ROX-33736: Add no-non-deprecated-PropTypes lint rule with ignores#19548
ROX-33736: Add no-non-deprecated-PropTypes lint rule with ignores#19548pedrottimark wants to merge 1 commit intomasterfrom
Conversation
|
Images are ready for the commit at 5eb20a2. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19548 +/- ##
=======================================
Coverage 49.26% 49.26%
=======================================
Files 2727 2727
Lines 205788 205788
=======================================
Hits 101376 101376
- Misses 96879 96880 +1
+ Partials 7533 7532 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@pedrottimark: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Objective
When we delete deprecated container folders, we intend to delete obsolete dependencies.
Problem
If non-deprecated files still depend on the dependencies (pardon pun) any additional unplanned technical investment might block deletion, because the effort will compete with other unplanned tasks.
Analysis
Find in Files
import PropTypeshas 172 results in 172 files.Solution
Use typescript-eslint playground to understand
import PropTypes from 'prop-types';statement.https://typescript-eslint.io/play/#ts=5.9.3&showAST=es&fileType=.tsx
Edit pluginLimited.js file.
no-non-deprecated-PropTypeslint rule.Edit eslint.config.js file.
ignoresarray and comments.User-facing documentation
Testing and quality
Automated testing
How I validated my change
npm run tscin ui/apps/platform folder.npm run lint:fast-devin ui/apps/platform folder.With configuration object but without
ignoresproperty see expected 172 errors.