ROX-33125: deprecation notices for helm and manifests#19552
Merged
Conversation
|
Skipping CI for Draft Pull Request. |
Contributor
Author
|
@porridge (and reviewers), I have a few follow-up questions after working on this change:
2. When creating an init bundle, users can select the "Helm chart" option as the installation method and download the bundle without seeing the deprecation warning. Should the warning be surfaced in the form itself?
3. The change mentions deprecation in `4.11.0` and removal in `5.1.0`. @porridge can you confirm that as still true for this? I'll dm PMs to make sure they're good with that as well.
|
Contributor
|
Images are ready for the commit at fbaeb2a. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19552 +/- ##
==========================================
- Coverage 49.28% 49.28% -0.01%
==========================================
Files 2735 2735
Lines 206215 206215
==========================================
- Hits 101633 101632 -1
- Misses 97041 97042 +1
Partials 7541 7541
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9aa7ee6 to
26a7a02
Compare
.../platform/src/Containers/Clusters/ClusterRegistrationSecrets/SecureClusterUsingHelmChart.tsx
Outdated
Show resolved
Hide resolved
ui/apps/platform/src/Containers/Clusters/InitBundles/SecureClusterUsingHelmChart.tsx
Outdated
Show resolved
Hide resolved
Contributor
Good idea!
Yes, and then I think we can also drop the
This is still very much the plan. |
porridge
approved these changes
Mar 25, 2026
Contributor
porridge
left a comment
There was a problem hiding this comment.
LGTM already, but will be even better with the additions you came up with!
porridge
reviewed
Mar 25, 2026
Base automatically changed from
ROX-33119/operator-instructions-non-openshift
to
master
March 25, 2026 16:29
Warn users that the rhacs/secured-cluster-services Helm chart and legacy manifest bundle installation methods are deprecated since 4.11 and will be removed in 5.1, recommending the Kubernetes operator instead. Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
26a7a02 to
22703ad
Compare
- Use Flex spaceItems prop instead of className utility classes for spacing, following PatternFly best practices - Convert React fragment to Flex in ClusterDeployment for consistent layout prop usage - Fix manifest bundle deprecation version from 4.11 to 4.9 - Add "(deprecated)" label to Helm chart tabs in init bundles, cluster registration secrets, and modal - Remove "(recommended)" from Operator option and add "(deprecated)" to Helm chart option in init bundle form Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
…ment Replace className utility class on deprecation Alert with FlexItem spacer prop for PatternFly-idiomatic spacing. Convert React fragment to Flex in ClusterDeployment for consistent layout component usage. Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
davdhacs
pushed a commit
that referenced
this pull request
Mar 26, 2026
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Jira: ROX-33125
Add deprecation warning alerts to the Helm chart and legacy manifest bundle installation flows in the cluster setup UI. Users are warned that:
rhacs/secured-cluster-servicesHelm chart is deprecated since 4.11 and will be removed in 5.1Warnings appear in:
User-facing documentation
Testing and quality
Automated testing
How I validated my change
npx tsc --noEmit)Screenshots