-
Notifications
You must be signed in to change notification settings - Fork 172
ROX-33550: Add doc links for operator install and deprecation notices #19554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sachaudh
wants to merge
4
commits into
master
Choose a base branch
from
ROX-33550/ui-doc-links-operator-deprecation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
449344a
feat(clusters): add doc links for operator install and deprecation no…
sachaudh f5476b5
refactor(clusters): extract InstallMethodDeprecationAlert component
sachaudh 52b163a
fix: version
sachaudh a455f7e
fix(clusters): resolve prettier formatting in deprecation message
sachaudh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
ui/apps/platform/src/Containers/Clusters/Components/InstallMethodDeprecationAlert.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| import type { ReactElement, ReactNode } from 'react'; | ||
| import { Alert, Content } from '@patternfly/react-core'; | ||
|
|
||
| import ExternalLink from 'Components/PatternFly/IconText/ExternalLink'; | ||
| import useMetadata from 'hooks/useMetadata'; | ||
| import { getVersionedDocs } from 'utils/versioning'; | ||
|
|
||
| export type InstallMethodDeprecationAlertProps = { | ||
| deprecationMessage: ReactNode; | ||
| }; | ||
|
|
||
| /** | ||
| * Shared deprecation warning alert used across cluster installation pages. | ||
| * Displays a configurable deprecation message and a link to operator installation docs. | ||
| */ | ||
| function InstallMethodDeprecationAlert({ | ||
| deprecationMessage, | ||
| }: InstallMethodDeprecationAlertProps): ReactElement { | ||
| const { version } = useMetadata(); | ||
|
|
||
| return ( | ||
| <Alert | ||
| title="Deprecation notice" | ||
| component="p" | ||
| variant="warning" | ||
| isInline | ||
| className="pf-v6-u-mb-lg" | ||
| > | ||
| <Content component="p">{deprecationMessage}</Content> | ||
| <Content component="p"> | ||
| Use the Kubernetes operator to install secured cluster services instead. | ||
| {version && ( | ||
| <> | ||
| {' '} | ||
| See{' '} | ||
| <ExternalLink> | ||
| <a | ||
| href={getVersionedDocs( | ||
| version, | ||
| 'installing/installing-rhacs-on-red-hat-openshift#install-secured-cluster-ocp' | ||
| )} | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| > | ||
| operator installation documentation | ||
| </a> | ||
| </ExternalLink> | ||
| . | ||
| </> | ||
| )} | ||
| </Content> | ||
| </Alert> | ||
| ); | ||
| } | ||
|
|
||
| export default InstallMethodDeprecationAlert; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kcarmichael08 We’ve added doc links to the deprecation notices on the Helm and manifest install pages. Each deprecation alert now links to "operator installation documentation" so users have a clear migration path.
Currently, the link points to the OpenShift operator install page (installing-rhacs-on-red-hat-openshift#install-secured-cluster-ocp). Two questions:
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, I think linking to OCP Operator installation docs is OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I think at this point it's available enough to be documentable. See this ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but that ticket was created two days ago, so there is no documentation available yet to add a link for in the GUI. So I cannot provide a link to documentation that is not yet created.
The parent ticket of ROX-33749 is a 4.11 ticket, so it would typically be done in the 4.11 cycle (which has not yet started for docs - as you know, our work lags behind development). When you say "enough to be documentable," were you expecting something now, before 4.11 docs are published?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense, Kerry. I don't think the intention of this PR is to assume that the docs are already in place. Just setting things up so that when the docs come in, we already have everything set up on the UI. If the external link still needs to be decided, we can either leave a comment in JIRA to revisit this and update the link or keep this open until that is decided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! We should have a better idea of the link after the drafts are done.