chore(AGENTS.md): Use maps in table-driven tests and testify asserts#19564
Merged
chore(AGENTS.md): Use maps in table-driven tests and testify asserts#19564
Conversation
|
Skipping CI for Draft Pull Request. |
8a5b32e to
2e9b64b
Compare
Contributor
|
Images are ready for the commit at 45213ee. To use with deploy scripts, first |
mtodor
approved these changes
Mar 24, 2026
Co-authored-by: Mladen Todorovic <mtodor@gmail.com>
Co-authored-by: Mladen Todorovic <mtodor@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19564 +/- ##
=======================================
Coverage 49.26% 49.26%
=======================================
Files 2727 2727
Lines 205821 205821
=======================================
+ Hits 101396 101405 +9
+ Misses 96889 96885 -4
+ Partials 7536 7531 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds testing guidelines to AGENTS.md so that agents prefer maps to store table-driven tests and use testify assertions.
I also reorganized the structure to pull some sections into a new "development" section rather than "architecture" (see db827a4).
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Verified that agents follow the new guidelines.