ROX-33758: Fix quadratic runtime in endpointsStore.addToHistory#19571
Open
rhacs-bot wants to merge 1 commit intorelease-4.9from
Open
ROX-33758: Fix quadratic runtime in endpointsStore.addToHistory#19571rhacs-bot wants to merge 1 commit intorelease-4.9from
endpointsStore.addToHistory#19571rhacs-bot wants to merge 1 commit intorelease-4.9from
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
benchmarkSeedEndpointsStore, the loopfor i := range numEndpointswill not compile sincerangecannot be used over anint; use a standard indexed loop likefor i := 0; i < numEndpoints; i++ { ... }instead. - In
BenchmarkEndpointsStoreAddToHistory,b.Loop()is not part of thetesting.BAPI and will fail to compile; replace it with the usualfor i := 0; i < b.N; i++ { ... }pattern to drive the benchmark iterations.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `benchmarkSeedEndpointsStore`, the loop `for i := range numEndpoints` will not compile since `range` cannot be used over an `int`; use a standard indexed loop like `for i := 0; i < numEndpoints; i++ { ... }` instead.
- In `BenchmarkEndpointsStoreAddToHistory`, `b.Loop()` is not part of the `testing.B` API and will fail to compile; replace it with the usual `for i := 0; i < b.N; i++ { ... }` pattern to drive the benchmark iterations.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
Author
|
Images are ready for the commit at db192e6. To use with deploy scripts, first |
Contributor
|
/konflux-retest operator-bundle-on-push |
1 similar comment
Contributor
|
/konflux-retest operator-bundle-on-push |
|
@rhacs-bot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
vikin91
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport bfd67f2 from #19566.