ROX-33771: Disable Delete for read-only role in auth providers list#19574
Conversation
|
Images are ready for the commit at 3a9c952. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19574 +/- ##
==========================================
- Coverage 49.26% 49.25% -0.01%
==========================================
Files 2735 2735
Lines 206138 206138
==========================================
- Hits 101546 101542 -4
- Misses 97045 97049 +4
Partials 7547 7547
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ui/apps/platform/src/Containers/AccessControl/AuthProviders/AuthProvidersList.tsx
Show resolved
Hide resolved
|
@pedrottimark: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Problem
Analysis
Row actions have
isDisabledcondition in 3 other list pages:That is, vertical ellipsis button is visible but disabled.
Delete row action has
isDisabledcondition in auth providers list page:That is, vertical ellipsis button is enabled.
Solution
Be consistent to disable row actions if user role does not have write
'Access'permission or during delete request for table row.User-facing documentation
Testing and quality
Automated testing
How I validated my change
npm run tscin ui/apps/platform folder.npm run lint:fast-devin ui/apps/platform folder.npm run startin ui/apps/platform folder with staging demo as central.Manual testing
Temporarily edit
hasWriteAccessForPagecondition.Visit /main/access-control/auth-providers
See vertical ellipsis button is visible but disabled.
