ROX-33544: Add Tailored Profile tab to compliance coverage#19575
Draft
ROX-33544: Add Tailored Profile tab to compliance coverage#19575
Conversation
|
Skipping CI for Draft Pull Request. |
Contributor
Author
|
Leaving this as a draft PR until I split up / move some of the logic and add automated test. |
Contributor
|
Images are ready for the commit at 6402861. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19575 +/- ##
=======================================
Coverage 49.25% 49.26%
=======================================
Files 2735 2735
Lines 206138 206138
=======================================
+ Hits 101539 101544 +5
+ Misses 97051 97047 -4
+ Partials 7548 7547 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a Tailored Profiles tab to compliance coverage so tailored profiles are separated from benchmark-based profiles.
Notes:
TAILORED_PROFILE) now show under a dedicated tabstandard.shortNamegetProfileTab/getStandardTabsprofiles[0], not “first tab / first profile”The source of truth here is a little awkward because the API returns a flat list of profiles, while the UI groups those profiles into tabs by derived benchmark name. In other words, the tabs do not exist in the response shape and have to be built on the client from
operatorKindandstandards[].That also means the route is still profile-first even though the UI feels tab-first. The selected tab is derived from the selected profile, so there is not really a single backend-provided source of truth for the tab state itself.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Manual testing
PROFILE/OPERATOR_KIND_UNSPECIFIEDstandard.shortName)shortNamevalues are ignoredTAILORED_PROFILEMixed profile list
Conditional tabs
Scan schedule filter change