ROX-33769: Add no-non-deprecated-Component lint rule with ignores#19582
Open
pedrottimark wants to merge 1 commit intomasterfrom
Open
ROX-33769: Add no-non-deprecated-Component lint rule with ignores#19582pedrottimark wants to merge 1 commit intomasterfrom
pedrottimark wants to merge 1 commit intomasterfrom
Conversation
Contributor
|
Images are ready for the commit at 069581c. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19582 +/- ##
==========================================
- Coverage 49.26% 49.26% -0.01%
==========================================
Files 2735 2735
Lines 206138 206138
==========================================
- Hits 101550 101549 -1
- Misses 97041 97042 +1
Partials 7547 7547
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Objective
When we delete deprecated container folders, we intend to have no more occurrences of superseded patterns.
Problem
The need to understand code that has superseded patterns:
Analysis
Find in Files
extends Componenthas 20 results in 20 files.Solution
Use typescript-eslint playground to understand
class Whatever extends Component { … }declaration.https://typescript-eslint.io/play/#ts=5.9.3&showAST=es&fileType=.tsx
Edit pluginLimited.js file.
no-non-deprecated-Componentlint rule.Edit eslint.config.js file.
ignoresarray and comments.Edit ErrorBoundary.tsx file
User-facing documentation
Testing and quality
Automated testing
How I validated my change
npm run tscin ui/apps/platform folder.npm run lint:fast-devin ui/apps/platform folder.With configuration object but without
ignoresproperty see expected 20 errors.