fix: enable gosec G402 (TLS MinVersion) linter rule#19588
Open
raajheshkannaa wants to merge 1 commit intostackrox:masterfrom
Open
fix: enable gosec G402 (TLS MinVersion) linter rule#19588raajheshkannaa wants to merge 1 commit intostackrox:masterfrom
raajheshkannaa wants to merge 1 commit intostackrox:masterfrom
Conversation
Add G402 to the gosec includes list in .golangci.yml and fix all violations across the codebase: - Add MinVersion: tls.VersionTLS12 to tls.Config structs that were missing it (production code, test helpers, test servers) - Add #nosec G402 annotations to intentional InsecureSkipVerify usages where TLS verification is user-configurable (notifiers, scanners, registries) or where mTLS provides authentication (sensor-to-central) - Add #nosec G402 annotations to test code that uses self-signed certs Fixes part of stackrox#3545
|
Hi @raajheshkannaa. Thanks for your PR. I'm waiting for a stackrox member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3545
Summary
.golangci.ymlto enforce TLS minimum version settingsMinVersion: tls.VersionTLS12to 15tls.Configstructs missing it#nosec G402annotations to 28 intentionalInsecureSkipVerifyusages with explanatory commentsCategories of nosec annotations
Changes
43 files changed, 59 insertions, 46 deletions
Test plan
golangci-lintpasses with G402 enabled