Skip to content

ROX-33330: Proto for targeted image cache invalidation in adm ctrl#19597

Draft
clickboo wants to merge 1 commit intomasterfrom
boo-adm-cntrl-targeted-invalidation-foundation
Draft

ROX-33330: Proto for targeted image cache invalidation in adm ctrl#19597
clickboo wants to merge 1 commit intomasterfrom
boo-adm-cntrl-targeted-invalidation-foundation

Conversation

@clickboo
Copy link
Contributor

@clickboo clickboo commented Mar 25, 2026 •
edited
Loading

Description

This is a foundational, proto only PR for implementing targeted image cache invalidation for admission controller.

Today, we purge admission controller image cache pretty aggressively. Optimal cache warmth is essential to reduce image fetch/scan calls and hence improve admission controller throughput and burst resilience at scale.

This PR introduces the protobuf messages which will be used by sensor in the future to invalidate only certain image cache keys.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

CI only given protobuf changes only.

@clickboo
Copy link
Contributor Author

clickboo commented Mar 25, 2026 •
edited
Loading

This change is part of the following stack:

Change managed by git-spice.

@openshift-ci
Copy link

openshift-ci bot commented Mar 25, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

sourcery-ai[bot]

This comment was marked as outdated.

Sign in to view

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Mar 25, 2026 •
edited
Loading

Images are ready for the commit at 4031ed6.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-437-g4031ed6b9e.

@codecov
Copy link

codecov bot commented Mar 25, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.28%. Comparing base (4f8098a) to head (4031ed6).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #19597   +/-   ##
=======================================
  Coverage   49.28%   49.28%           
=======================================
  Files        2735     2735           
  Lines      206215   206215           
=======================================
+ Hits       101633   101639    +6     
+ Misses      97041    97036    -5     
+ Partials     7541     7540    -1
Flag Coverage Δ
go-unit-tests 49.28% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@clickboo clickboo force-pushed the boo-adm-cntrl-targeted-invalidation-foundation branch from 8d1867f to 4031ed6 Compare March 25, 2026 10:48
@clickboo clickboo changed the title ROX-33328,ROX-33330: Generation counters, foundation for targeted cache invalidation ROX-33330: Proto for targeted image invalidation in admission controller Mar 25, 2026
@clickboo clickboo changed the title ROX-33330: Proto for targeted image invalidation in admission controller ROX-33330: Proto for targeted image cache invalidation in adm ctrl Mar 25, 2026
@clickboo clickboo mentioned this pull request Mar 25, 2026
Draft
9 tasks
@clickboo
Copy link
Contributor Author

clickboo commented Mar 25, 2026

/test all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ai-review area/admission-controller area/sensor do-not-merge/work-in-progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@clickboo @rhacs-bot