perf(ci): use fixed version ldflags for tests to enable GOCACHE hits#19617
Draft
perf(ci): use fixed version ldflags for tests to enable GOCACHE hits#19617
Conversation
Tests don't need real version info. Use fixed version strings (0.0.0-test) instead of git-describe values for test ldflags. This makes link ActionIDs stable across commits, enabling Go's test result cache to hit. Also adds -buildvcs=false to stop Go 1.18+'s VCS stamping which independently changes link ActionIDs on every commit. Builds keep the current XDef/status.sh mechanism unchanged. Verified locally: tests cache across commits with fixed ldflags. Combined with the mtime fix (#19395), this enables full warm test caching in CI (2.5-8.2x faster test jobs). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Skipping CI for Draft Pull Request. |
This was referenced Mar 25, 2026
Contributor
|
Images are ready for the commit at fdfe8cb. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19617 +/- ##
=======================================
Coverage 49.28% 49.28%
=======================================
Files 2735 2735
Lines 206215 206215
=======================================
+ Hits 101627 101636 +9
+ Misses 97046 97038 -8
+ Partials 7542 7541 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use fixed version strings for test ldflags instead of git-describe values. This makes link ActionIDs stable across commits, enabling Go's test result cache.
Change: When
TOOL=test, skipstatus.shand use0.0.0-testfor all version-Xldflags. Builds keep the current XDef/status.sh mechanism unchanged.Also adds
-buildvcs=false(Go 1.18+ VCS stamping changes link ActionIDs per commit).Why this works
Go includes ldflags in the link ActionID. Changing
-X MainVersion=...g<sha>per commit gives every test binary a new ActionID, preventing test result caching. Fixed ldflags = stable ActionIDs = cache hits.Verification
Note: This PR fixes test cache Phase 1 (stable binary identity). Full test caching also requires #19395 (mtime fix for Phase 2). See the combined branch
davdhacs/test-cache-combined-minimalfor both together.Partially generated by AI.