ROX-33255: Allow TLS 1.0/1.1 in tlsprofile#19652
Open
vladbologa wants to merge 1 commit intomasterfrom
Open
Conversation
Contributor
|
Images are ready for the commit at 176b313. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19652 +/- ##
==========================================
+ Coverage 49.34% 49.37% +0.03%
==========================================
Files 2742 2742
Lines 206953 206953
==========================================
+ Hits 102126 102190 +64
+ Misses 97231 97181 -50
+ Partials 7596 7582 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/test gke-qa-e2e-tests |
Contributor
Author
|
/test ocp-4-12-qa-e2e-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When implementing the configurable TLS profiles for Go-based Stackrox applications, I chose to reject minimum TLS versions lower than 1.2, to not allow decreasing the Stackrox security posture from the previous hardcoded defaults.
Here I am revisiting that decision. With the upcoming OpenShift cluster-wide TLS profile support (ROX-33336), a cluster admin can configure the
OldTLS profile withStrictAllComponentsadherence, which requires TLS 1.0. To be compliant, we should accept also these settings. Moreover, PostgreSQL components already accept TLS 1.0/1.1 (they use the literal settings provided to them - see #19160), which would cause an inconsistency in behavior between Stackrox services.The defaults remain unchanged: TLS 1.2 minimum with AES-256 preferred ciphers. TLS 1.0/1.1 is only used when explicitly requested.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!