ROX-33792: extract operator bundle build to separate job#19656
Open
ROX-33792: extract operator bundle build to separate job#19656
Conversation
Extract operator bundle generation from the build-and-push-operator matrix job into a standalone build-operator-bundle job. Changes: - Add new build-operator-bundle job that runs on ubuntu-latest - Job has no dependencies (starts immediately for max parallelism) - Fixed RHACS_BRANDING only (no matrix, no community bundle) - Includes Python setup for bundle helper scripts - Remove bundle build/push/index steps from build-and-push-operator job - Update slack-on-build-failure to depend on build-operator-bundle Benefits: - Maximum parallelism: bundle starts immediately, no waiting - No wasted matrix slots on conditional bundle steps - Simpler operator build matrix (only handles operator images) - No container overhead (runs on host with Go + Python + Docker) - Cleaner separation of bundle vs operator image logic Related: ROX-33792 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new
build-operator-bundlejob always runs withROX_PRODUCT_BRANDING: RHACS_BRANDING; if this workflow is also used for upstream/STACKROX branding, consider adding a conditional (similar to the previousmatrix.name != 'STACKROX_BRANDING'check) so you don’t build/push RHACS-specific bundles on non-RHACS runs. - QUAY credentials are currently exposed as job-level environment variables; consider scoping
QUAY_RHACS_ENG_RW_USERNAME/QUAY_RHACS_ENG_RW_PASSWORDonly to the login/push steps to minimize their visibility across unrelated steps.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `build-operator-bundle` job always runs with `ROX_PRODUCT_BRANDING: RHACS_BRANDING`; if this workflow is also used for upstream/STACKROX branding, consider adding a conditional (similar to the previous `matrix.name != 'STACKROX_BRANDING'` check) so you don’t build/push RHACS-specific bundles on non-RHACS runs.
- QUAY credentials are currently exposed as job-level environment variables; consider scoping `QUAY_RHACS_ENG_RW_USERNAME`/`QUAY_RHACS_ENG_RW_PASSWORD` only to the login/push steps to minimize their visibility across unrelated steps.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
Images are ready for the commit at 6b13f56. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19656 +/- ##
=======================================
Coverage 49.37% 49.37%
=======================================
Files 2743 2743
Lines 207020 207020
=======================================
+ Hits 102215 102219 +4
+ Misses 97221 97218 -3
+ Partials 7584 7583 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
davdhacs
reviewed
Mar 27, 2026
| github.event_name == 'push' || !github.event.pull_request.head.repo.fork | ||
| run: | | ||
| ./scripts/ci/lib.sh registry_rw_login "quay.io/${QUAY_ORG}" | ||
| make -C operator/ docker-push-bundle | cat |
Contributor
Author
There was a problem hiding this comment.
It was in the original job so I just copied it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extract operator bundle generation from the build-and-push-operator matrix job into a standalone build-operator-bundle job.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
CI