ROX-30858: optimize OSS notice generation in build workflow#19658
ROX-30858: optimize OSS notice generation in build workflow#19658
Conversation
Move OSS notice generation from build-and-push-main matrix job to a new dedicated pre-build-oss-notice job that runs once. Previously, OSS notice was generated 4-8+ times per workflow run (once per branding × architecture combination in the matrix). Since the THIRD_PARTY_NOTICES file is identical across all runs (same go.mod and package-lock.json), this was wasteful. Changes: - Add new pre-build-oss-notice job that generates OSS notice once - Upload as shared artifact consumed by all build-and-push-main matrix cells - Remove redundant UI cache, UI deps, and OSS generation from build-and-push-main - Reduces OSS generation from 4-8+ times to exactly 1 time (75-87% reduction) ROX-30858 Partially generated by AI.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19658 +/- ##
=======================================
Coverage 49.38% 49.38%
=======================================
Files 2743 2743
Lines 207037 207037
=======================================
+ Hits 102236 102245 +9
+ Misses 97218 97212 -6
+ Partials 7583 7580 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| - uses: ./.github/actions/download-artifact-with-retry | ||
| with: | ||
| name: oss-notice | ||
| path: image/rhel/ |
There was a problem hiding this comment.
| path: image/rhel/ | |
| path: image/rhel/THIRD_PARTY_NOTICES |
There was a problem hiding this comment.
Great idea! It looks like the image/rhel/THIRD_PARTY_NOTICES in the upload gets archived without the "THIRD_PARTY_NOTICES"
|
@janisz: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Move OSS notice generation from build-and-push-main matrix job to a new dedicated pre-build-oss-notice job that runs once.
Previously, OSS notice was generated 4-8+ times per workflow run (once per branding × architecture combination in the matrix). Since the THIRD_PARTY_NOTICES file is identical across all runs (same go.mod and package-lock.json), this was wasteful.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
CI