Skip to content

ROX-30352: define VirtualMachineV2Service proto with all RPCs#19663

Draft
ajheflin wants to merge 1 commit intomasterfrom
aheflin/ROX-30352/vm-v2-service-proto
Draft

ROX-30352: define VirtualMachineV2Service proto with all RPCs#19663
ajheflin wants to merge 1 commit intomasterfrom
aheflin/ROX-30352/vm-v2-service-proto

Conversation

@ajheflin
Copy link
Copy Markdown
Contributor

@ajheflin ajheflin commented Mar 27, 2026 •
edited by atlassian bot
Loading

Description

Part 1/6 of the VirtualMachineV2Service API stack (ROX-30352).

Defines the full gRPC/REST API contract for the new VirtualMachineV2Service with 10 endpoints serving the V2 normalized data model for VM vulnerability management. All messages, enums, and RPC definitions are included upfront so that the UnimplementedServer stub provides safe defaults while endpoints are delivered incrementally in follow-up PRs.

No behavioral change - the service is not registered yet.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

No tests needed - proto definitions and generated code only. Compilation verified locally.

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

  • make proto-generated-srcs succeeds
  • go build ./generated/api/v2/... compiles cleanly
  • make proto-style passes

@ajheflin @claude
ROX-30352: define VirtualMachineV2Service proto with all RPCs
faf5bbe 
Define the full API contract for the new VirtualMachineV2Service with 10
REST endpoints serving the V2 normalized data model for VM vulnerability
management. Uses the UnimplementedServer stub pattern so endpoints can be
delivered incrementally in follow-up PRs.

No behavioral change — the service is not registered yet.

Partially generated by AI.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 27, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 27, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ee6fe625-a935-4232-8828-8a570abe02cd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch aheflin/ROX-30352/vm-v2-service-proto

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ajheflin
Copy link
Copy Markdown
Contributor Author

ajheflin commented Mar 27, 2026

This change is part of the following stack:

Change managed by git-spice.

This was referenced Mar 27, 2026
Draft
Draft
Draft
Draft
Draft
@ajheflin ajheflin requested a review from dashrews78 March 27, 2026 18:14
@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented Mar 27, 2026

Images are ready for the commit at faf5bbe.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-472-gfaf5bbeb20.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.38%. Comparing base (7837075) to head (faf5bbe).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #19663   +/-   ##
=======================================
  Coverage   49.37%   49.38%           
=======================================
  Files        2743     2743           
  Lines      207020   207037   +17     
=======================================
+ Hits       102215   102235   +20     
+ Misses      97221    97219    -2     
+ Partials     7584     7583    -1
Flag Coverage Δ
go-unit-tests 49.38% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dashrews78 dashrews78 Awaiting requested review from dashrews78

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ai-assisted do-not-merge/work-in-progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ajheflin @rhacs-bot