Skip to content

chore(revert): "ROX-33792: optimize git checkout with shallow clones (#19615)"#19682

Closed
rhybrillou wants to merge 1 commit intomasterfrom
yann/revert-shallow-clone
Closed

chore(revert): "ROX-33792: optimize git checkout with shallow clones (#19615)"#19682
rhybrillou wants to merge 1 commit intomasterfrom
yann/revert-shallow-clone

Conversation

@rhybrillou
Copy link
Copy Markdown
Contributor

This reverts commit 630af16.

Description

Recent PR builds fail non-groovy tests. The symptoms suggest a release image is used instead of a development one for these tests.
The reverted commit seems to touch some of the build conditions, so this PRs tests if the revert fixes the CI runs

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

How I validated my change

PR CI run

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rhacs-bot
Copy link
Copy Markdown
Contributor

Images are ready for the commit at 0c40c21.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-474-g0c40c21a1a.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.38%. Comparing base (0737966) to head (0c40c21).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #19682   +/-   ##
=======================================
  Coverage   49.37%   49.38%           
=======================================
  Files        2743     2743           
  Lines      207037   207037           
=======================================
+ Hits       102223   102243   +20     
+ Misses      97228    97212   -16     
+ Partials     7586     7582    -4     
Flag Coverage Δ
go-unit-tests 49.38% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rhybrillou rhybrillou changed the title Revert "ROX-33792: optimize git checkout with shallow clones (#19615)" chore(revert): "ROX-33792: optimize git checkout with shallow clones (#19615)" Mar 30, 2026
@rhybrillou
Copy link
Copy Markdown
Contributor Author

It seems rebasing the failing PRs fixes the tests.

@rhybrillou rhybrillou closed this Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants