ROX-33893: Support glob patterns in telemetry header names#19687
Draft
parametalol wants to merge 1 commit intomasterfrom
Draft
ROX-33893: Support glob patterns in telemetry header names#19687parametalol wants to merge 1 commit intomasterfrom
parametalol wants to merge 1 commit intomasterfrom
Conversation
Change telemetry campaign header matching from exact string keys to glob pattern keys. This allows matching multiple headers with a single pattern (e.g., "Rh-*" instead of hardcoding specific header names). Changes: - Updated APICallCampaignCriterion.Headers from map[string]glob.Pattern to map[glob.Pattern]glob.Pattern - Added HeadersFilter func to RequestParams for pattern-based filtering - Implemented Headers.GetAll method for glob-based header matching - Updated ServiceNow integration to use "Rh-*" pattern - Added comprehensive test coverage This change was requested to make telemetry header tracking more flexible for integrations that may use varying header names with common prefixes. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Skipping CI for Draft Pull Request. |
Contributor
|
Images are ready for the commit at 628b5f8. To use with deploy scripts, first |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19687 +/- ##
========================================
Coverage 49.37% 49.38%
========================================
Files 2742 2743 +1
Lines 206953 207074 +121
========================================
+ Hits 102187 102263 +76
- Misses 97182 97227 +45
Partials 7584 7584
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances telemetry header matching by allowing glob patterns in header names, not just header values. Previously, telemetry campaigns could only match exact header names with pattern values. Now both header names and values can use glob patterns.
Key changes:
APICallCampaignCriterion.Headersfrommap[string]glob.Patterntomap[glob.Pattern]glob.PatternHeadersFilterfunction toRequestParamsfor pattern-based header filteringHeaders.GetAllmethod that matches both header names and values using globs"Rh-*"pattern instead of hardcoded"Rh-ServiceNow-Integration"Motivation:
The ServiceNow integration sets headers with a common prefix, but the exact header name may vary. Using glob patterns for header names allows tracking multiple related headers without hardcoding each variant.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
headers_multimap_test.gocovering various glob pattern scenariosinterceptors_test.go,campaign_test.go, andrequest_params_test.goto use the new pattern-based header matching"Rh-*"pattern🤖 Generated with Claude Code