Skip to content

ROX-33925: bump github.com/russellhaering/goxmldsig from 1.5.0 to 1.6.0#19690

Open
vladbologa wants to merge 1 commit intorelease-4.8from
vb/bump-goxmldsig-4.8
Open

ROX-33925: bump github.com/russellhaering/goxmldsig from 1.5.0 to 1.6.0#19690
vladbologa wants to merge 1 commit intorelease-4.8from
vb/bump-goxmldsig-4.8

Conversation

@vladbologa
Copy link
Copy Markdown
Contributor

@vladbologa vladbologa commented Mar 30, 2026

Description

Bump github.com/russellhaering/goxmldsig to 1.6.0 to fix CVE-2026-33487

Note that Stackrox is not affected by CVE-2026-33487 because it uses go > 1.22, but patching this will nevertheless help to not get flagged incorrectly by scanners.

Related to ROX-33866 ROX-33867 ROX-33868 ROX-33869

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

CI is sufficient

@github-actions github-actions bot added the backport PR to backport changes from master to release branch label Mar 30, 2026
@rhacs-bot
Copy link
Copy Markdown
Contributor

Images are ready for the commit at 2ad1c4b.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.10-rc.2-1-g2ad1c4b2ab.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.73%. Comparing base (88f2a43) to head (2ad1c4b).

Additional details and impacted files
@@               Coverage Diff               @@
##           release-4.8   #19690      +/-   ##
===============================================
- Coverage        48.73%   48.73%   -0.01%     
===============================================
  Files             2595     2595              
  Lines           190828   190828              
===============================================
- Hits             93009    93000       -9     
- Misses           90507    90515       +8     
- Partials          7312     7313       +1     
Flag Coverage Δ
go-unit-tests 48.73% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vladbologa vladbologa changed the title chore(deps): bump github.com/russellhaering/goxmldsig from 1.5.0 to 1.6.0 ROX-33925: bump github.com/russellhaering/goxmldsig from 1.5.0 to 1.6.0 Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport PR to backport changes from master to release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants