Skip to content

ROX-33652: Update API proto for Enhanced VM Report Filters#19699

Open
c-du wants to merge 1 commit intomasterfrom
cong/filters
Open

ROX-33652: Update API proto for Enhanced VM Report Filters#19699
c-du wants to merge 1 commit intomasterfrom
cong/filters

Conversation

@c-du
Copy link
Copy Markdown
Contributor

@c-du c-du commented Mar 30, 2026

Description

Update API v2 for report filter models.

change me!

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@c-du c-du requested a review from ksurabhi91 March 30, 2026 19:03
@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented Mar 30, 2026

Images are ready for the commit at 14abf26.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-447-g14abf26e6c.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.65%. Comparing base (c14d8db) to head (14abf26).
⚠️ Report is 42 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #19699      +/-   ##
==========================================
+ Coverage   49.28%   49.65%   +0.37%     
==========================================
  Files        2735     2747      +12     
  Lines      206215   207261    +1046     
==========================================
+ Hits       101627   102910    +1283     
+ Misses      97046    96697     -349     
- Partials     7542     7654     +112
Flag Coverage Δ
go-unit-tests 49.65% <ø> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 30, 2026

@c-du: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-scanner-v4-install-tests 14abf26 link false /test gke-scanner-v4-install-tests
ci/prow/gke-upgrade-tests 14abf26 link false /test gke-upgrade-tests
ci/prow/gke-nongroovy-e2e-tests 14abf26 link true /test gke-nongroovy-e2e-tests
ci/prow/ocp-4-21-nongroovy-e2e-tests 14abf26 link false /test ocp-4-21-nongroovy-e2e-tests
ci/prow/gke-qa-e2e-tests 14abf26 link false /test gke-qa-e2e-tests
ci/prow/ocp-4-21-qa-e2e-tests 14abf26 link false /test ocp-4-21-qa-e2e-tests
ci/prow/ocp-4-12-qa-e2e-tests 14abf26 link false /test ocp-4-12-qa-e2e-tests
ci/prow/ocp-4-12-scanner-v4-install-tests 14abf26 link false /test ocp-4-12-scanner-v4-install-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ksurabhi91 ksurabhi91 ksurabhi91 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@c-du @rhacs-bot @ksurabhi91