Open
Conversation
Contributor
|
Images are ready for the commit at c6898b8. To use with deploy scripts, first |
Contributor
Author
|
/test gke-nongroovy-e2e-tests |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-4.8 #19736 +/- ##
===============================================
- Coverage 48.73% 48.73% -0.01%
===============================================
Files 2595 2595
Lines 190828 190828
===============================================
- Hits 93009 92999 -10
- Misses 90507 90515 +8
- Partials 7312 7314 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The OCM golang SDK used to depend on an old version of pgx, which in turn pulled the vulnerable pgproto3.
A recent release of the OCM SDK got rid of that dependency. This change updates the project dependency to use that recent SDK release.
This also addresses ROX-33876 , ROX-33877 , and ROX-33878 .
User-facing documentation
is updated ORupdate is not neededis created and is linked above ORis not neededTesting and quality
Automated testing
The existing CI should cover the impacted functionalities.
How I validated my change
CI run.