ROX-32158: Add E2E tests for label-based policy scoping#19756
ROX-32158: Add E2E tests for label-based policy scoping#19756
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19756 +/- ##
========================================
Coverage 49.59% 49.60%
========================================
Files 2763 2763
Lines 208167 208271 +104
========================================
+ Hits 103250 103312 +62
- Misses 97252 97292 +40
- Partials 7665 7667 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Images are ready for the commit at 5a354f7. To use with deploy scripts, first |
|
Images are ready for the commit at 3ae3dca. To use with deploy scripts, first |
5a354f7 to
f83fbcf
Compare
qa-tests-backend/src/test/groovy/AdmissionControllerTest.groovy
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Looks like we already have non groovy test so maybe we don't need this test
There was a problem hiding this comment.
There's a slight difference here in what each is testing. the Go tests are verifying that label-scoped policies detect violations and generate alerts, while the Groovy tests are verifying that label-scoped policies enforce at admission time and actually block deployments from being created.
If there's an easier way to do this (and remove the groovy tests entirely) I'd be happy to remove them, but I do think the coverage is important in one place or another.
… E2E tests for admission control label scoping
c7944d3 to
b6f51fe
Compare
🚀 Build Images ReadyImages are ready for commit 89a8605. To use with deploy scripts: export MAIN_IMAGE_TAG=4.11.x-548-g89a860597e |
|
/retest |
|
@AlexVulaj: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
This PR adds comprehensive integration test coverage for the label-based policy scoping feature (ROX-32158), specifically testing
cluster_labelandnamespace_labelfields in policy scope objects.The label-based policy scoping feature was previously implemented end-to-end but lacked integration test coverage for regression protection. This PR addresses that gap by adding both Go E2E tests and Groovy integration tests for admission control.
User-facing documentation
Testing and quality
Automated testing
How I validated my change