Skip to content

ROX-19064: Scanner V4 DB CI - PVC Storage Class#19833

Draft
dcaravel wants to merge 2 commits intomasterfrom
dc/scan4-infra-storageclass
Draft

ROX-19064: Scanner V4 DB CI - PVC Storage Class#19833
dcaravel wants to merge 2 commits intomasterfrom
dc/scan4-infra-storageclass

Conversation

@dcaravel
Copy link
Copy Markdown
Contributor

@dcaravel dcaravel commented Apr 5, 2026

Description

Using an SSD backed PVC for Scanner V4 DB will help it be ready quickly in CI.

This PR enables the PVC's Storage Class name to be configured per job and sets that name for various jobs known to benefit from it. This is necessary because jobs deploy to different cluster flavors which use different storage class names.

The storage class name is set appropriately regardless which of the 3 supported install mechanisms are used (manifest, helm, or operator)

Not every job requires this setting, for example the OCP targets use "ssd-csi" is the default storage class. Leaving the name unset will result in the cluster's default storage class being used.

In the future when/if all cluster flavors are updated to use a SSD storage class by default the explicit settings can be removed. For now this change favored a path of least resistance that is easy to reason about.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

The changes themselves are tests

How I validated my change

Against StackRox Scanner these changes will be tested by CI as part of this PR

Against Scanner V4 these changes were validated in #19236 and will be validated again in a future PR when Scanner V4 is officially turned on in CI.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 5, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dcaravel
Copy link
Copy Markdown
Contributor Author

dcaravel commented Apr 5, 2026

/test all

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.60%. Comparing base (2d5d7a2) to head (a5062f0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #19833   +/-   ##
=======================================
  Coverage   49.60%   49.60%           
=======================================
  Files        2763     2763           
  Lines      208339   208339           
=======================================
  Hits       103341   103341           
  Misses      97331    97331           
  Partials     7667     7667           
Flag Coverage Δ
go-unit-tests 49.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

🚀 Build Images Ready

Images are ready for commit a5062f0. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.11.x-562-ga5062f0d70

@dcaravel
Copy link
Copy Markdown
Contributor Author

dcaravel commented Apr 5, 2026

/test gke-qa-e2e-tests

@dcaravel dcaravel marked this pull request as ready for review April 6, 2026 04:19
@dcaravel dcaravel marked this pull request as draft April 6, 2026 04:19
@dcaravel
Copy link
Copy Markdown
Contributor Author

dcaravel commented Apr 6, 2026

/test all

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 6, 2026

@dcaravel: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-21-nongroovy-e2e-tests a5062f0 link false /test ocp-4-21-nongroovy-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant