Open
Conversation
|
Skipping CI for Draft Pull Request. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19835 +/- ##
=======================================
Coverage 49.60% 49.60%
=======================================
Files 2763 2763
Lines 208339 208359 +20
=======================================
+ Hits 103341 103353 +12
- Misses 97331 97339 +8
Partials 7667 7667
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
🚀 Build Images ReadyImages are ready for commit c4e6e53. To use with deploy scripts: export MAIN_IMAGE_TAG=4.11.x-561-gc4e6e53703 |
Contributor
Author
|
/test all |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to set an allow list of bundles for which to import into Scanner V4 DB.
While enabling Scanner V4, CI jobs were timing out due to taking ~40m to load vulns occasionally.
CI can be sped up by not loading data that isn't utilized in tests, such as SUSE which was taking ~18m to load in GKE tests.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Manually via modifying the scanner-v4-matcher-config configmap, adding key:
And then observing via logs, database, and comparing before/after scans the only the expected data was loaded:
Scanned
quay.io/rhacs-eng/main:4.9.0before and after - differences were as expected (ie: OSV vulns were missing)Scanned
nginx:1.23.0before and after - no vulns in the latter which is expected - image is debian based and no debian vulns were loaded.