Skip to content

ROX-34019: Revert change to VulnMgmtTest RHEL image#19877

Merged
dcaravel merged 2 commits intomasterfrom
dc/fix-ci-scan-fail
Apr 8, 2026
Merged

ROX-34019: Revert change to VulnMgmtTest RHEL image#19877
dcaravel merged 2 commits intomasterfrom
dc/fix-ci-scan-fail

Conversation

@dcaravel
Copy link
Copy Markdown
Contributor

@dcaravel dcaravel commented Apr 7, 2026

Description

#19642 updated the test images used to work for both Scanner V2 and V4, this caused e2e tests to flake (see ROX-34019)

This is a legit bug in Scanner V2 that older images tested would not encounter (see ROX-34058)

The bug randomly causes the scan to yield no results, was able to reproduce by repeatedly scanning the test image, and clearing scanner-db image tables in-between attempts.

>>> 2026-04-07T23:35:34Z OS=rhel:9 Components=186
>>> 2026-04-07T23:36:51Z OS=rhel:9 Components=186
>>> 2026-04-07T23:38:18Z OS=rhel:9 Components=186
>>> 2026-04-07T23:39:34Z OS=rhel:9 Components=186
>>> 2026-04-07T23:40:51Z OS=rhel:9 Components=186
>>> 2026-04-07T23:42:08Z OS=centos:9 Components=0  <-- Broken
>>> 2026-04-08T00:01:09Z OS=centos:9 Components=0  <-- Broken
>>> 2026-04-08T00:01:19Z OS=rhel:9 Components=186
>>> 2026-04-08T00:01:28Z OS=rhel:9 Components=186
>>> 2026-04-08T00:01:37Z OS=rhel:9 Components=186
>>> 2026-04-08T00:01:46Z OS=rhel:9 Components=186
>>> 2026-04-08T00:01:54Z OS=rhel:9 Components=186
>>> 2026-04-08T00:02:03Z OS=rhel:9 Components=186
>>> 2026-04-08T00:02:12Z OS=rhel:9 Components=186
>>> 2026-04-08T00:02:22Z OS=rhel:9 Components=186
>>> 2026-04-08T00:02:31Z OS=centos:9 Components=0  <-- Broken
>>> 2026-04-08T00:08:21Z OS=centos:9 Components=0  <-- Broken
>>> 2026-04-08T00:08:39Z OS=rhel:9 Components=186
>>> 2026-04-08T00:08:48Z OS=rhel:9 Components=186
>>> 2026-04-08T00:08:57Z OS=rhel:9 Components=186
>>> 2026-04-08T00:09:06Z OS=rhel:9 Components=186
>>> 2026-04-08T00:09:15Z OS=rhel:9 Components=186
>>> 2026-04-08T00:09:23Z OS=rhel:9 Components=186
>>> 2026-04-08T00:09:32Z OS=rhel:9 Components=186
>>> 2026-04-08T00:09:41Z OS=rhel:9 Components=186
>>> 2026-04-08T00:09:49Z OS=rhel:9 Components=186
>>> 2026-04-08T00:09:58Z OS=rhel:9 Components=186
>>> 2026-04-08T00:10:07Z OS=rhel:9 Components=186
>>> 2026-04-08T00:10:16Z OS=rhel:9 Components=186
>>> 2026-04-08T00:10:25Z OS=rhel:9 Components=186
>>> 2026-04-08T00:10:35Z OS=rhel:9 Components=186
>>> 2026-04-08T00:10:44Z OS=centos:9 Components=0  <-- Broken

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • modified existing tests

How I validated my change

CI

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 7, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dcaravel
Copy link
Copy Markdown
Contributor Author

dcaravel commented Apr 7, 2026

/test all

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

🚀 Build Images Ready

Images are ready for commit 811f960. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.11.x-596-g811f960e66

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.58%. Comparing base (27bf450) to head (ba55ab0).
⚠️ Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19877      +/-   ##
==========================================
- Coverage   49.58%   49.58%   -0.01%     
==========================================
  Files        2766     2766              
  Lines      208530   208540      +10     
==========================================
+ Hits       103406   103408       +2     
- Misses      97451    97460       +9     
+ Partials     7673     7672       -1     
Flag Coverage Δ
go-unit-tests 49.58% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dcaravel dcaravel changed the title ROX-34019: fix ci flake ROX-34019: Revert change to VulnMgmtTest RHEL image Apr 7, 2026
@dcaravel dcaravel force-pushed the dc/fix-ci-scan-fail branch from d05b1d0 to 0052ecc Compare April 7, 2026 23:48
@dcaravel dcaravel force-pushed the dc/fix-ci-scan-fail branch from 0052ecc to ba55ab0 Compare April 7, 2026 23:51
@dcaravel dcaravel marked this pull request as ready for review April 8, 2026 00:12
@dcaravel dcaravel requested a review from janisz as a code owner April 8, 2026 00:12
@dcaravel dcaravel requested review from a team, charmik-redhat and clickboo April 8, 2026 00:23
@dcaravel dcaravel added the auto-retest PRs with this label will be automatically retested if prow checks fails label Apr 8, 2026
@dcaravel
Copy link
Copy Markdown
Contributor Author

dcaravel commented Apr 8, 2026

/test gke-nongroovy-e2e-tests

@rhacs-bot
Copy link
Copy Markdown
Contributor

/retest

@dcaravel dcaravel merged commit 811f960 into master Apr 8, 2026
116 checks passed
@dcaravel dcaravel deleted the dc/fix-ci-scan-fail branch April 8, 2026 12:39
janisz added a commit that referenced this pull request Apr 8, 2026
Added PR reference tracking to show which PRs link to each Jira issue
that has missing metadata.

Example output:
- ROX-33451: ✗ fixVersion, ✗ affectedVersion (Assignee: ..., Team: ..., Component: ...) (PRs: #19382)
- ROX-34000: ✗ fixVersion, ✗ affectedVersion (Assignee: ..., Team: ..., Component: ...) (PRs: #19876, #19877)

Implementation:
- Track jira_key → PR numbers mapping while checking metadata
- Include PR links at end of Jira issue line
- Multiple PRs shown as comma-separated list with links

Makes it easier to identify which PRs need Jira metadata updates.

Partially generated with AI assistance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-retest PRs with this label will be automatically retested if prow checks fails

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants