Skip to content

ROX-33655: Query changes for enahnced filters#19881

Draft
ksurabhi91 wants to merge 1 commit intomasterfrom
query_enhanced_filters
Draft

ROX-33655: Query changes for enahnced filters#19881
ksurabhi91 wants to merge 1 commit intomasterfrom
query_enhanced_filters

Conversation

@ksurabhi91
Copy link
Copy Markdown
Contributor

Description

change me!

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 7, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

🚀 Build Images Ready

Images are ready for commit 75378cb. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.11.x-584-g75378cbe79

@ksurabhi91 ksurabhi91 force-pushed the query_enhanced_filters branch 2 times, most recently from 44b7c0a to dd7d511 Compare April 7, 2026 23:14
@ksurabhi91 ksurabhi91 force-pushed the query_enhanced_filters branch from dd7d511 to 75378cb Compare April 7, 2026 23:46
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

❌ Patch coverage is 69.92481% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.60%. Comparing base (9c983b6) to head (75378cb).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
central/reports/common/query_builder.go 63.00% 37 Missing ⚠️
.../reports/scheduler/v2/reportgenerator/testutils.go 90.32% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19881      +/-   ##
==========================================
+ Coverage   49.58%   49.60%   +0.01%     
==========================================
  Files        2766     2766              
  Lines      208530   208662     +132     
==========================================
+ Hits       103408   103512     +104     
- Misses      97450    97475      +25     
- Partials     7672     7675       +3     
Flag Coverage Δ
go-unit-tests 49.60% <69.92%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant