perf(ci): Remove golangci-lint warmup pass#19900
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19900 +/- ##
=======================================
Coverage 49.58% 49.58%
=======================================
Files 2766 2766
Lines 208535 208535
=======================================
Hits 103409 103409
Misses 97448 97448
Partials 7678 7678
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🚀 Build Images ReadyImages are ready for commit 14014f0. To use with deploy scripts: export MAIN_IMAGE_TAG=4.11.x-598-g14014f0902 |
|
Example runs from earlier today to compare with: a PR took 27m18s: on master took 24m2s: |
davdhacs
left a comment
There was a problem hiding this comment.
22m 44s
proves saving ~5 minutes 🚀
|
@AlexVulaj: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
This PR removes the golangci-lint warmup pass that was previously run in CI before the main linting passes. The warmup pass (golangci-lint run --tests=false) was originally added in ROX-17014 to warm up the cache and reduce the runtime of subsequent linting passes to about 5 minutes each.
With recent CI infrastructure improvements (particularly the removal of containers from the go jobs in commit f0fa0ff), the warmup pass may no longer provide meaningful performance benefits and adds unnecessary complexity to the linting workflow. Removing it simplifies the CI linting process while maintaining the same code quality checks.
The change removes 4 lines from the Makefile that executed the warmup pass with limited scope (no tests). All other linting passes remain unchanged, including the standard pass with no tags (which now includes the unused linter) and the release tags pass.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
CI will validate that golangci-lint still runs successfully without the warmup pass - will monitor CI execution times to ensure no significant performance regression. The linting checks themselves remain identical, just without the initial warmup run.