ROX-33089: Improve language on scope step of wizard#19903
ROX-33089: Improve language on scope step of wizard#19903
Conversation
|
|
||
| return ( | ||
| <PolicyScopeCardBase title="Exclusion scope" onDelete={onDelete}> | ||
| <PolicyScopeCardBase title="Excluded resource" onDelete={onDelete}> |
There was a problem hiding this comment.
I would rename to Exclusion (since it is not a singular resource per rule, but will most likely be a set of resources - put differently - it is a single rule, not a single resource). Also this is the card that pops up when the user clicks on "Add exclusion".
There was a problem hiding this comment.
(not sure if this shows up in the UI - I think this is the card title which does)
|
|
||
| return ( | ||
| <PolicyScopeCardBase title="Inclusion scope" onDelete={onDelete}> | ||
| <PolicyScopeCardBase title="Included resource" onDelete={onDelete}> |
There was a problem hiding this comment.
Similar suggestion: Inclusion
| title={`Delete ${type} scope`} | ||
| title={ | ||
| type === 'inclusion' | ||
| ? 'Delete included resource' |
There was a problem hiding this comment.
Delete inclusion/exclusion
| <Flex direction={{ default: 'column' }}> | ||
| <Title headingLevel="h3">Included resources</Title> | ||
| <div> | ||
| Define which clusters, namespaces, and deployments this policy |
There was a problem hiding this comment.
I know my demo said deployments but given RFEs to exclude other workload types like Jobs and CronJobs coming soon, would be nice to use workloads as the verbiage instead of deployments. I believe we are encouraging that terminology in other parts of the UI as well cc: @mansursyed
🚀 Build Images ReadyImages are ready for commit a62ec3e. To use with deploy scripts: export MAIN_IMAGE_TAG=4.11.x-601-ga62ec3ee95 |
1 similar comment
🚀 Build Images ReadyImages are ready for commit a62ec3e. To use with deploy scripts: export MAIN_IMAGE_TAG=4.11.x-601-ga62ec3ee95 |
| <Flex direction={{ default: 'column' }}> | ||
| <Title headingLevel="h3">Excluded resources</Title> | ||
| <div> | ||
| Excluded resources define what this policy will not evaluate. They |
There was a problem hiding this comment.
Exclude one or more clusters, namespaces, or workloads (if applicable) from this policy.
OR
Define one or more clusters, namespaces or workloads (if applicable) to be excluded from this policy.
| </div> | ||
| <Flex direction={{ default: 'column' }}> | ||
| <Title headingLevel="h3">Included resources</Title> | ||
| <div> |
There was a problem hiding this comment.
Apply this policy to one or more clusters, namespaces or workloads (if applicable).
OR
Define one or more clusters, namespaces of workloads (if applicable) to apply this policy to.
followed by:
If no inclusions are configured, the policy will apply to all resources in your environment, except those excluded.
(Because of the "except those excluded" , it shortens the exclusion description and succinctly conveys "They narrow the result of your inclusions (or all resources, if you added
none)."
pedrottimark
left a comment
There was a problem hiding this comment.
Technical changes are solid.
Thank you Brad for discussion on Slack about markup, which is relevant to text elsewhere.
Description
Improves UX copy for the policy resources step in the wizard
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Before
After