perf(ci): Skip generated/mock packages in roxvet#19926
perf(ci): Skip generated/mock packages in roxvet#19926
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19926 +/- ##
=======================================
Coverage 49.55% 49.55%
=======================================
Files 2760 2760
Lines 208065 208065
=======================================
Hits 103113 103113
Misses 97311 97311
Partials 7641 7641
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🚀 Build Images ReadyImages are ready for commit 53ffa80. To use with deploy scripts: export MAIN_IMAGE_TAG=4.11.x-612-g53ffa8021c |
|
/retest |
|
@AlexVulaj: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Updated roxvet to skip analyzing code in generated/ directories and mocks/ packages. These directories contain auto-generated code from protobuf definitions and GoMock mocks. The check-generated-files job in the Style workflow already ensures generated code stays up to date by running make proto-generated-srcs and make go-generated-srcs, so skipping roxvet analysis on these files doesn't reduce coverage.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Verified that generated/mock packages are excluded from roxvet analysis while maintaining test coverage. The
check-generated-filesjob in the Style workflow continues to validate these files by regenerating them and checking for diffs. CI run showed roxvet execution time reduced from ~12.5 minutes to ~5.5 minutes, saving ~7 minutes per workflow run.