ROX-19064: Scanner V4 CI Wait for Vulns to Load (readiness version)#19930
Open
ROX-19064: Scanner V4 CI Wait for Vulns to Load (readiness version)#19930
Conversation
|
Skipping CI for Draft Pull Request. |
Contributor
Author
|
/test all |
Contributor
🚀 Build Images ReadyImages are ready for commit 9ad24ea. To use with deploy scripts: export MAIN_IMAGE_TAG=4.11.x-614-g9ad24eac34 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19930 +/- ##
=======================================
Coverage 49.55% 49.56%
=======================================
Files 2764 2764
Lines 208346 208346
=======================================
+ Hits 103254 103265 +11
+ Misses 97437 97428 -9
+ Partials 7655 7653 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Alternative to: #19836 (only one is needed)
Adds the rails for CI jobs to wait for vuln loads to finish before starting tests.
This PR modifies Scanner V4 Matcher behavior such that the pod will not become ready until vulns fully loaded by default. Jobs that do not want this behavior must explicitly set
SCANNER_V4_VULN_READINESStofalse(assumes the majority of jobs will want this behavior once Scanner V4 is enabled for all)Prior to polling the available storage classes are listed for the cluster to assist troubleshooting if loads are slow (to verify if the DB PVC is using an SSD), additionally each poll dumps the current top pods cpu/mem consumption to assist in troubleshooting/measuring (as needed).
User-facing documentation
Testing and quality
Automated testing
How I validated my change
CI