Conversation
|
Images are ready for the commit at 658ab8b. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-4.8 #19964 +/- ##
============================================
Coverage 48.73% 48.73%
============================================
Files 2595 2595
Lines 190828 190828
============================================
+ Hits 93002 93004 +2
+ Misses 90513 90512 -1
+ Partials 7313 7312 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/konflux-retest operator-bundle-on-push |
1 similar comment
|
/konflux-retest operator-bundle-on-push |
|
@dvail: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| "version": "4.0.0", | ||
| "resolved": "https://registry.npmjs.org/immutable/-/immutable-4.0.0.tgz", | ||
| "integrity": "sha1-uG943mre82CDle+yaakUYnl+LCM= sha512-zIE9hX70qew5qTUjSS7wi1iwj/l7+m54KWU247nhM3v806UdGj1yDndXj+IOYxxtW9zyLI+xqFNZjTuDaLUqFw==", | ||
| "version": "4.3.8", |
There was a problem hiding this comment.
@dvail Is 4.3.8 the intended change for 4.8 release branch?
There was a problem hiding this comment.
Yeah, this was the automatic "latest version" that was resolved by npm. Different from the 4.9 and 4.10 branches because those branches have a dependency on immutable ^3.x.
It does seem odd that this branch, while older, gets the newer version of the dependency. What do you think? Keep it in line with the 4.9 and 4.10 branches? Or downgrade from 4.0.0 to 3.8.3 here?
Description
Update optional peer dep
immutableto the latest.User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!