Skip to content

ROX-34135: Update konflux node.js build image to v24#19967

Open
bradr5 wants to merge 1 commit intomasterfrom
bradr/ROX-34135_update_konflux_node_build_image_v24
Open

ROX-34135: Update konflux node.js build image to v24#19967
bradr5 wants to merge 1 commit intomasterfrom
bradr/ROX-34135_update_konflux_node_build_image_v24

Conversation

@bradr5
Copy link
Copy Markdown
Contributor

@bradr5 bradr5 commented Apr 13, 2026

Description

Node.js 20 reaches end of support April 2026. This updates the Konflux build image to Node.js 24.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Ran npm install && npm run build locally with node 24

@bradr5 bradr5 requested a review from a team April 13, 2026 18:13
@bradr5 bradr5 requested review from a team and rhacs-bot as code owners April 13, 2026 18:13
@github-actions github-actions bot added area/helm konflux-build Run Konflux in PR. Push commit to trigger it. labels Apr 13, 2026
@rhacs-bot rhacs-bot requested a review from a team April 13, 2026 18:14
msugakov
msugakov approved these changes Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@msugakov msugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. As easy as that. Please make sure Red Hat Konflux / main-on-push completes successfully. It may flake so please re-run https://redhat.atlassian.net/wiki/spaces/StackRox/pages/309338850/How+to+re-run+Konflux+pipelines

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 13, 2026 •
edited
Loading

🚀 Build Images Ready

Images are ready for commit ed58600. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.11.x-636-ged58600b28

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.56%. Comparing base (75d765a) to head (ed58600).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #19967   +/-   ##
=======================================
  Coverage   49.56%   49.56%           
=======================================
  Files        2764     2764           
  Lines      208422   208422           
=======================================
  Hits       103310   103310           
  Misses      97457    97457           
  Partials     7655     7655
Flag Coverage Δ
go-unit-tests 49.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 13, 2026

/konflux-retest main-on-push

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 13, 2026

/konflux-retest main-on-push

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 13, 2026

/konflux-retest operator-bundle-on-push

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 13, 2026

/konflux-retest operator-bundle-on-push

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 13, 2026

/konflux-retest main-on-push

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 13, 2026

@bradr5: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-qa-e2e-tests ed58600 link false /test ocp-4-12-qa-e2e-tests
ci/prow/ocp-4-21-qa-e2e-tests ed58600 link false /test ocp-4-21-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 13, 2026

/konflux-retest operator-bundle-on-push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msugakov msugakov msugakov approved these changes

@rhacs-bot rhacs-bot Awaiting requested review from rhacs-bot rhacs-bot is a code owner

Assignees

No one assigned

Labels

area/helm konflux-build Run Konflux in PR. Push commit to trigger it.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bradr5 @msugakov