ROX:34136, ROX:34137: Fix tagless images' name and link display under CVE and Deployment pages#19992
Open
charmik-redhat wants to merge 1 commit intomasterfrom
Conversation
… images Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19992 +/- ##
=======================================
Coverage 49.57% 49.57%
=======================================
Files 2765 2765
Lines 208478 208482 +4
=======================================
+ Hits 103354 103358 +4
Misses 97468 97468
Partials 7656 7656
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
🚀 Build Images ReadyImages are ready for commit cd9d549. To use with deploy scripts: export MAIN_IMAGE_TAG=4.11.x-649-gcd9d549bee |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
FlattenImageDatais enabled, the image id field becomes a UUID instead of a SHA digest. Several views in Workload CVEs used the id field as a fallback display value for tagless images (viaImageNameLinkandgetImageBaseNameDisplay), causing UUIDs to appear instead of digests.This PR adds a digest field to the Image GraphQL type and passes it to the UI so that tagless images always display the SHA digest regardless of the FlattenImageData flag.
Changes
Backend — central/graphql/resolvers/images.go
UI — ImageResourceTable.tsx (Deployment single page → Resources tab)
UI — table.utils.ts (Workload CVE single page)
ImageNameLink renders an image name.
The ImageNameLink component (ImageNameLink.tsx:30) already prefers digest over id when present (const imageShaForDisplay = digest || id), so the fix is purely about fetching and passing the
new field.
User-facing documentation
Testing and quality
Automated testing
How I validated my change