ROX-34151: Add Reports subfolder to Components folder#19994
Open
pedrottimark wants to merge 1 commit intomasterfrom
Open
ROX-34151: Add Reports subfolder to Components folder#19994pedrottimark wants to merge 1 commit intomasterfrom
pedrottimark wants to merge 1 commit intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19994 +/- ##
=======================================
Coverage 49.61% 49.61%
=======================================
Files 2765 2765
Lines 208596 208596
=======================================
Hits 103493 103493
Misses 97444 97444
Partials 7659 7659
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
🚀 Build Images ReadyImages are ready for commit 87ccc28. To use with deploy scripts: export MAIN_IMAGE_TAG=4.11.x-652-g87ccc281c3 |
1 similar comment
Contributor
🚀 Build Images ReadyImages are ready for commit 87ccc28. To use with deploy scripts: export MAIN_IMAGE_TAG=4.11.x-652-g87ccc281c3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Objective
Provide equivalent filter for schduled reports as view-based reports
Analysis
Details and (deferred pending decision about its name) Destinations or Delivery files are reusable for both image and node vulnerability report configuraiton (not to mention violations).
Solution
Factor out as discussed in office hours similar to CompoundSearchFilter subfolder.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
npm run tscin ui/apps/platform folder.npm run lint:fast-devin ui/apps/platform folder.