Skip to content

ROX-34151: Add Reports subfolder to Components folder #19994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pedrottimark merged 1 commit into from
Apr 16, 2026
Merged

ROX-34151: Add Reports subfolder to Components folder #19994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ilityReports/Wizard/Step1/DetailsStep.tsx → ...c/Components/Reports/Step/DetailsStep.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { ReactElement } from 'react';
import { Divider, Flex, PageSection, Title } from '@patternfly/react-core';

// import type { DetailsType } from '../../imageVulnerabilityReports.types';
// import type { DetailsType } from '../reports.types';

function DetailsStep(): ReactElement {
return (
Expand Down
2 changes: 1 addition & 1 deletion ...VulnerabilityReports/View/DetailsView.tsx → ...c/Components/Reports/View/DetailsView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
Title,
} from '@patternfly/react-core';

import type { DetailsType } from '../imageVulnerabilityReports.types';
import type { DetailsType } from '../reports.types';

export type DetailsViewProps = {
headingLevel: 'h2' | 'h3';
Expand Down
4 changes: 4 additions & 0 deletions ui/apps/platform/src/Components/Reports/reports.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
export type DetailsType = {
name: string;
description: string;
};
5 changes: 0 additions & 5 deletions ...c/Containers/Vulnerabilities/ImageVulnerabilityReports/imageVulnerabilityReports.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,6 @@ import type {
import type { VulnerabilitySeverity } from 'types/cve.proto';
import type { Schedule } from 'types/schedule.proto';

export type DetailsType = {
name: string;
description: string;
};

// TODO move final type to ReportsService.types.ts file when merged into report_service.proto file

type EntityScope = {
Expand Down
Loading