ROX-8729: Generate local scanner TLS certificates in Central#211
Merged
ROX-8729: Generate local scanner TLS certificates in Central#211
Conversation
|
Tag for build #65004 is 💻 For deploying this image using the dev scripts, run the following first: export MAIN_IMAGE_TAG='3.67.x-226-g278ee720b4'📦 You can also generate an installation bundle with: docker run -i --rm stackrox/main:3.67.x-226-g278ee720b4 central generate interactive > bundle.zip🕹️ A |
porridge
requested changes
Jan 3, 2022
4 tasks
added 2 commits
January 3, 2022 15:30
Referring to the expiration time, instead of to components
porridge
reviewed
Jan 4, 2022
porridge
approved these changes
Jan 5, 2022
Contributor
porridge
left a comment
There was a problem hiding this comment.
Ooooh, this is almost perfect!
My only concern is that generateServiceCertMap will typically get called twice in a row, and while the key/cert bytes are cached by readCA*, the CA object itself will need to be set up twice. But this is probably best addressed in the next PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Generate local scanner TLS certificates in Central
Checklist
Testing Performed
Unit tests added to check compliance wrt design doc. Here I'm assuming that Scanner DB has the same expiration and additional subject alternative name as Scanner, and that those were not added to the design doc due to a typo