ROX-11349: Add rationale and guidance text according to product feedback#2150
Merged
ROX-11349: Add rationale and guidance text according to product feedback#2150
Conversation
|
Skipping CI for Draft Pull Request. |
|
Tag for build #714371 is 💻 For deploying this image using the dev scripts, run the following first: export MAIN_IMAGE_TAG='3.70.x-449-g05d9983857'🕹️ A |
|
Images are ready for the commit at 05d9983. To use with deploy scripts, first |
Contributor
Author
|
/test gke-upgrade-tests |
Contributor
Author
|
/retest |
Contributor
Author
|
/test all |
vikin91
approved these changes
Jun 28, 2022
Contributor
vikin91
left a comment
There was a problem hiding this comment.
LGTM!
The comments are strictly cosmetic and are optional.
...rkpolicy_guidance/policies_before_and_after/after/deployment_has_ingress_network_policy.json
Outdated
Show resolved
Hide resolved
migrator/migrations/m_103_to_m_104_networkpolicy_guidance/migration.go
Outdated
Show resolved
Hide resolved
…ation.go Co-authored-by: Piotr Rygielski <114479+vikin91@users.noreply.github.com>
…cies_before_and_after/after/deployment_has_ingress_network_policy.json Co-authored-by: Piotr Rygielski <114479+vikin91@users.noreply.github.com>
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds text fields updated according to product's suggestion in ROX-11110.
Checklist
Unit test and regression tests addedDetermined and documented upgrade stepsDocumented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)Testing Performed