[ROX-10775] : Node Vulnerability GraphQL Endpoint tests#2815
[ROX-10775] : Node Vulnerability GraphQL Endpoint tests#2815charmik-redhat merged 7 commits intomasterfrom
Conversation
|
Skipping CI for Draft Pull Request. |
|
/test all |
fa214e5 to
c8e0cc6
Compare
|
Images are ready for the commit at f7975dd. To use with deploy scripts, first |
c913335 to
dfa8864
Compare
| return vuln | ||
| } | ||
|
|
||
| func testNodes() []*storage.Node { |
There was a problem hiding this comment.
Could you please move this function to the test_utils.go file, this could be reused in future tests on the node endpoint
There was a problem hiding this comment.
Yeah that's right. Moved the function.
|
|
||
| vuln := s.getImageVulnerabilityResolver(ctx, "cve-2018-1#") | ||
|
|
||
| scopedCtx := scoped.Context(ctx, scoped.Scope{ |
There was a problem hiding this comment.
Please get rid of scopedCtx since it is no longer being used
There was a problem hiding this comment.
scopedCtx is needed to fetch the ImageVulnerabilityResolver that is component scoped by calling getImageVulnerabilityResolver.
| s.Error(err) | ||
| } | ||
|
|
||
| func (s *GraphQLNodeVulnerabilityTestSuite) TestTopNodeVulnerability() { |
There was a problem hiding this comment.
We should test that top vuln changes when scoped
There was a problem hiding this comment.
Yeah, testing it when it is node scoped in this test. I will add the test for when it is component scoped when adding node components tests.
8771776 to
f7975dd
Compare
|
/retest-required |
Update SCANNER_VERSION and COLLECTOR_VERSION to reference images from their respective UBI9 migration PRs: - Scanner: 2.38.x-166-g16d772deeb (PR #2562) - includes arm64 build fix - Collector: 3.23.x-132-g98b7877e58 (PR #2815) This enables e2e tests to verify all three components work correctly together with UBI9. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Description
Checklist
[ ] Evaluated and added CHANGELOG entry if required[ ] Determined and documented upgrade steps[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.
In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.