Skip to content

ROX-12510: Optimize VM widget queries#3021

Merged
vjwilson merged 2 commits intomasterfrom
ROX-12510-optimize-VM-widget-queries
Sep 9, 2022
Merged

ROX-12510: Optimize VM widget queries#3021
vjwilson merged 2 commits intomasterfrom
ROX-12510-optimize-VM-widget-queries

Conversation

@vjwilson
Copy link
Contributor

@vjwilson vjwilson commented Sep 8, 2022

Description

  1. another perf optimization: imageCount is called twice https://github.com/stackrox/stackrox/blob/master/ui/apps/platform/src/Containers/VulnMgmt/widgets/MostCommonVulnerabilities.js#L37
  2. and here: https://github.com/stackrox/stackrox/blob/master/ui/apps/platform/src/Containers/VulnMgmt/widgets/MostCommonVulnerabiltiesInDeployment.js#L41

Checklist

  • Investigated and inspected CI test results (postgres test suite failure is unrelated flake due to missing cert)

Testing Performed

Manual testing (the widgets still work)

@ghost
Copy link

ghost commented Sep 8, 2022

Images are ready for the commit at 3e7974e.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.72.x-3-g3e7974e306.

scoreVersion
isFixable
deploymentCount
imageCount
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

count 1...count 2 ...count 3 ... 💥

@openshift-ci
Copy link

openshift-ci bot commented Sep 9, 2022

@vjwilson: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-postgres-qa-e2e-tests 3e7974e link false /test gke-postgres-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vjwilson vjwilson merged commit fa4592e into master Sep 9, 2022
@vjwilson vjwilson deleted the ROX-12510-optimize-VM-widget-queries branch September 9, 2022 13:54
janisz added a commit that referenced this pull request Mar 19, 2026
Following the pattern from collector PR #3021, this commit:
- Adds ubi-micro-base stage and copies it to /out/ before package installation to preserve rpmdb
- Removes bash and coreutils from dnf install (already included in ubi-micro)

The previous implementation installed packages to /out/ without first copying the ubi-micro base, which could break the RPM database. This pattern ensures the minimal ubi-micro base is preserved correctly.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
janisz added a commit that referenced this pull request Mar 19, 2026
Following the pattern from konflux.Dockerfile and collector PR #3021:
- Add ubi-micro-base stage and copy to /out/ before package installation to preserve rpmdb
- Install ca-certificates and openssl using dnf --installroot pattern
- Move roxctl binary to /usr/bin/roxctl for consistency

This aligns the main Dockerfile with the konflux.Dockerfile pattern,
providing a minimal but functional base image.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants