ROX-11101: Remove deprecated resources from UI#3098
Conversation
|
Skipping CI for Draft Pull Request. |
|
/test all |
|
/test all |
| "resourceToAccess": { | ||
| "Access": "NO_ACCESS", | ||
| "Administration": "NO_ACCESS", | ||
| "Administration": "READ_ACCESS", |
There was a problem hiding this comment.
This change is because of Config which has read access.
Now allowed by Administration are the services that used to be tied to the DebugLogs permission, and which could allow data leaks. Keeping NO_ACCESS here could also be a good idea.
There was a problem hiding this comment.
Thank you for comment. UI team needs to review whether this fixture is or should be same as Analyst role.
|
/retest |
0d026e3 to
f137334
Compare
|
/retest |
|
Images are ready for the commit at 9311186. To use with deploy scripts, first |
pedrottimark
left a comment
There was a problem hiding this comment.
Thank you for careful work.
After you merge,UI team can follow up:
- Remove
useIntegrationPermissionswhich is no longer needed. - Refactor to avoid repeated
replacedResourceMappingfor remaining old resources.
…ctive instead of least restrictive
…e are missing a proper deprecation note.
3e5ff8d to
9311186
Compare
Description
The set resources used for access control is being simplified.
A number of resources has been deprecated.
The goal here is to get rid of the deprecated resources, both in the database and in the codebase (UI, QA, central, DB). This PR focuses on the UI codebase removal.
Checklist
- [ ] Evaluated and added CHANGELOG entry if required- [ ] Determined and documented upgrade steps- [ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)If any of these don't apply, please comment below.
Testing Performed
CI is sufficient