Special case the global OpenShift image pull secret#3278
Conversation
|
/test all |
|
@connorgorman: No presubmit jobs available for stackrox/stackrox@cgorman-image-integration-fix DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Images are ready for the commit at d9668da. To use with deploy scripts, first |
5fb921d to
91aeec7
Compare
|
@dhaus67 making sure you saw this? I can try to review it if things are not clear, just wanted to make sure it doesn't get lost |
|
@misberner: Most of the changes are from #2572 , I already reviewed that one prior. I'll refactor this PR to not include the changes from #2572 so its better to review, would appreciate a second look from you as well (preferably on both, if you got the time for it, the first one is quite big). |
91aeec7 to
5ffba36
Compare
pkg/images/enricher/enricher_impl.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func isOpenshiftGlobalRegistry(source *storage.ImageIntegration_Source) bool { |
There was a problem hiding this comment.
| func isOpenshiftGlobalRegistry(source *storage.ImageIntegration_Source) bool { | |
| func isOpenshiftGlobalPullSecret(source *storage.ImageIntegration_Source) bool { |
the pull secret has nothing to do with an OpenShift registry, at least not necessarily so
26bc630 to
d9668da
Compare
|
@connorgorman: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
CI flakes are addressed with #3471 , so merging this. |
Co-authored-by: Daniel Haus <dhaus@redhat.com>
Description
This PR is an enhancement of #2572 and takes into account existing global pull secrets.
Openshift offers a global pull secret named
pull-secretin theopenshift-confignamespace.This pull secret can be used to give access to registries on a global scale, with the pull secret being rolled out to each nodes respective container runtime configuration.
The PR will make sure that the global pull secret will be added to the pull secrets for a specific image, irrespective of whether it's not matching in e.g. namespace.
Checklist
- [ ] Unit test and regression tests added- [ ] Evaluated and added CHANGELOG entry if required- [ ] Determined and documented upgrade steps- [ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)Testing Performed